Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Invert StartDealParams fast retrieval param #3026

Closed
wants to merge 1 commit into from
Closed

api: Invert StartDealParams fast retrieval param #3026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/api_full.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ type StartDealParams struct {
EpochPrice types.BigInt
MinBlocksDuration uint64
DealStartEpoch abi.ChainEpoch
FastRetrieval bool
NoFastRetrieval bool
VerifiedDeal bool
}

Expand Down
2 changes: 1 addition & 1 deletion api/test/deals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ func startDeal(t *testing.T, ctx context.Context, miner TestStorageNode, client
Miner: maddr,
EpochPrice: types.NewInt(1000000),
MinBlocksDuration: uint64(build.MinDealDuration),
FastRetrieval: fastRet,
NoFastRetrieval: !fastRet,
})
if err != nil {
t.Fatalf("%+v", err)
Expand Down
4 changes: 2 additions & 2 deletions cli/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ var clientDealCmd = &cli.Command{
EpochPrice: types.BigInt(price),
MinBlocksDuration: uint64(dur),
DealStartEpoch: abi.ChainEpoch(cctx.Int64("start-epoch")),
FastRetrieval: cctx.Bool("fast-retrieval"),
NoFastRetrieval: !cctx.Bool("fast-retrieval"),
VerifiedDeal: isVerified,
})
if err != nil {
Expand Down Expand Up @@ -610,7 +610,7 @@ func interactiveDeal(cctx *cli.Context) error {
EpochPrice: epochPrice,
MinBlocksDuration: uint64(epochs),
DealStartEpoch: abi.ChainEpoch(cctx.Int64("start-epoch")),
FastRetrieval: cctx.Bool("fast-retrieval"),
NoFastRetrieval: !cctx.Bool("fast-retrieval"),
VerifiedDeal: false, // TODO: Allow setting
})
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion node/impl/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func (a *API) ClientStartDeal(ctx context.Context, params *api.StartDealParams)
Price: params.EpochPrice,
Collateral: big.Zero(),
Rt: rt,
FastRetrieval: params.FastRetrieval,
FastRetrieval: !params.NoFastRetrieval,
VerifiedDeal: params.VerifiedDeal,
StoreID: storeID,
})
Expand Down