allow storage miners to manage a blocklist of piece CIDs #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
magik6k
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
So I guess this is better than nothing at all, but we'll need to expand it into its own module, with some more features
- Using datastore instead of the config
- Use double-hashed CIDs
- Don't pipe entire blocklists over RPC
- (future) Potentially allow calling external services handling blocklists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Addresses the storage provider side of this request from @whyrusleeping.
What's in this PR?
This PR adds three new commands
lotus-storage-miner deals get-blocklist(writes the piece CID blocklist to stdout, one per line, using the specified encoding),lotus-storage-miner deals set-blocklist(replaces the existing storage miner piece CID-blocklist with the contents of the provided file or the CIDs read from stdin), andlotus-storage-miner deals reset-blocklist, which wipes the storage miner's blocklist.