Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-fil-markets #1670

Merged
merged 2 commits into from
May 5, 2020
Merged

Update go-fil-markets #1670

merged 2 commits into from
May 5, 2020

Conversation

hannahhoward
Copy link
Contributor

Goals

Update go-fil-markets to the latest version to solve various issues (CHANGELOG coming)

Implementation

The changes required of lotus are as follows:

  • This PR includes an update for go-graphsync which includes a major, breaking update of go-ipld-prime (cc: @warpfork) -- while the changes are almost entirely under-the-hood from Lotus standpoint (and bonus should include some speed improvements for Graphsync) there are a few syntax changes in the way ipld-prime is called that affect mostly the Graphsync Client for chainsync.
  • go-car is also updated, which means we also have made module path renames, as the go-car repository moved to the ipld organization
  • our node apis that submit messages to chain now wait for those messages SEPERATE from the call to submit the message. While it's not ideal to wait for messages, this is still a major improvement over waiting for those messages inside of a blocking call that also submits them. The adapters have changed to accommodate the new APIs. (a future update will move away from waiting for messages to observing state)
  • go-data-transfer now uses a saved counter instead of an in-memory one. The constructors have been updated to reflect this.

Update to latest 0.2.0 release of go-fil-markets with less-blocking node io
@hannahhoward
Copy link
Contributor Author

Blocked pending merge of filecoin-project/go-fil-markets#223

@hannahhoward hannahhoward marked this pull request as ready for review May 5, 2020 21:45
@magik6k magik6k merged commit 10fe608 into testnet/3 May 5, 2020
@magik6k magik6k deleted the feat/update-markets-0.2.0 branch May 5, 2020 23:45
Kubuxu pushed a commit that referenced this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants