Improve offline deals #1515
Closed
Improve offline deals #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
approved these changes
Apr 6, 2020
|
Thanks to some suggestions from @hannahhoward , this is no longer needs a go-fil-markets update, and is thus no longer blocked by #183. |
api/apistruct/struct.go
Outdated
| @@ -111,6 +111,8 @@ type FullNodeStruct struct { | |||
| ClientListDeals func(ctx context.Context) ([]api.DealInfo, error) `perm:"write"` | |||
| ClientRetrieve func(ctx context.Context, order api.RetrievalOrder, ref api.FileRef) error `perm:"admin"` | |||
| ClientQueryAsk func(ctx context.Context, p peer.ID, miner address.Address) (*storagemarket.SignedStorageAsk, error) `perm:"read"` | |||
| ClientCalcCommP func(ctx context.Context, path string, miner address.Address) (*api.CommPRet, error) `perm:"read"` | |||
| ClientGenCar func(ctx context.Context, ref api.FileRef, path string) error `perm:"write"` | |||
There was a problem hiding this comment.
is this an out path? maybe name it 'out' or 'outpath' if so
whyrusleeping
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the offline deal workflow works.