Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for dual VM execution for getting the price list #8060

Closed
arajasek opened this issue Feb 10, 2022 · 2 comments
Closed

Allow for dual VM execution for getting the price list #8060

arajasek opened this issue Feb 10, 2022 · 2 comments
Labels
area/fvm kind/test Kind: Test P2 P2: Should be resolved
Milestone

Comments

@arajasek
Copy link
Contributor

Build on top of #8059 to run every tipset through both the Lotus VM and the ref-fvm. This should be relatively easy to do. We probably want to:

  • use the Lotus VM for the "real" validation
  • use the FVM-with-lotus-gas-costs and make sure it always results in the same state as the lotus VM
  • Add fuel accounting with unlimited fuel to trace fuel/gas statistics for the FVM itself (for the M1 milestone)
@arajasek arajasek added this to the Network v16 milestone Feb 10, 2022
@jennijuju jennijuju added area/fvm P1 P1: Must be resolved labels Feb 16, 2022
@jennijuju
Copy link
Member

this is mostly for testing purpose (gas comparison) and the code should not land in master

@jennijuju jennijuju added the kind/test Kind: Test label Feb 16, 2022
@jennijuju jennijuju changed the title Allow for dual VM execution Allow for dual VM execution for getting the price list Feb 16, 2022
@jennijuju jennijuju added P2 P2: Should be resolved and removed P1 P1: Must be resolved labels Mar 8, 2022
@jennijuju
Copy link
Member

We are uncertain this is necessary for the new gas model work scope. will confirm.

Repository owner moved this from Todo to Done in Network v16 (Skyr) - FVM M1 Upgrade Mar 14, 2022
@jennijuju jennijuju moved this from Done to Deferred in Network v16 (Skyr) - FVM M1 Upgrade Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fvm kind/test Kind: Test P2 P2: Should be resolved
Projects
No open projects
Status: Deferred
Development

No branches or pull requests

2 participants