-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on restart, all older active deals error out on 1.11.2-rc1 #7214
Comments
|
I'm suspecting the issue is caused by this pr #5431. |
Market node logs for an example of a deal that was active and then on downgrade went to error state grep bafyreibscuk7oqvapys76r7iyo5aabu23o5alqmyuh6c35awhna2hgfkti /market/logs/markets.log |
The deal ID assigned to a deal on-chain can change if there is a chain re-org. We do this lookup
The problem is that chain data gets GCed, so if the publish message is in a block that has been GCed from the local node's chain data, we will fail when trying to look up the deal by publish message CID. I think the correct solution is to
The definition of "recent" in this context is determined by
We need to choose a value between these two numbers |
That's a finality, but realistically even in the 20~100 epoch range you'll see basically no reorgs
Not sure about splitstore (cc @vyzo), but after importing from a snapshot you may only have one finality. We can also just special-case the deal message not being found, and gracefully fallback to looking at the deal ID |
Updating to latest master does not resolve this.
lotus-miner info Miner Balance: 1633.652 FIL Sectors: Storage Deals: 68, 760 GiB Retrieval Deals (complete): 191, 1.04 TiB |
@stuberman thanks for reporting the issue and we have identified the bug. @dirkmc will work on a script to help bring back the right deal status locally! |
Issue resolved by @dirkmc |
Checklist
Latest release
, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Lotus Version
Describe the Bug
I was running on a current Master pull, when I was asked to downgrade to 1.11.2-rc1 for testing.
(I have also been using various builds such as 'back-to-ocl-nemo' at the request of nemo.)
I have more than 2500 active deals, but now when I run lotus-miner info I only see 11 active deals and storage-deals list shows most deals are errored now (except deals processed today)
Logging Information
Repo Steps
...
The text was updated successfully, but these errors were encountered: