Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual retry of deal publishing #7102

Closed
3 tasks done
f8-ptrk opened this issue Aug 17, 2021 · 2 comments · Fixed by filecoin-project/go-fil-markets#638 or #7454
Closed
3 tasks done

Allow manual retry of deal publishing #7102

f8-ptrk opened this issue Aug 17, 2021 · 2 comments · Fixed by filecoin-project/go-fil-markets#638 or #7454
Assignees
Labels
Milestone

Comments

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Aug 17, 2021

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

lotus miner/market - storage deal

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

Aug 17 07:37:02 true bafyreictx7dwv4u5wdrqakwcfyahslpgrnccilr3kmz4k3gwhi6vz4wt4a 0 StorageDealError f1wdxdpqh3hirrhp353i4o6ld7bsw6evh3v7i5jtq 32GiB 0 FIL 520216 12D3KooWQKcgS3UBAG9WNJiV57iXRMx9bY2jD86aPPb5Y
NWvVEJe-12D3KooWMyP6mT7SC1AqnLqxzQQASuWooqnCrzBGXgUtQPsaERqq-1629176818622218181 error calling node: publishing deal: mpool push: failed to push message: not enough funds (required: 0.049999999994707184 FIL, balance: 0.010645432316105853 FIL): not enough funds to execute transaction

this could be recovered easily - right now its a 100% fail

Describe the solution you'd like

a retry failed publish deals/deal command

Describe alternatives you've considered

No response

Additional context

No response

@neondragon
Copy link

+1
It would be great if Lotus could better differentiate between recoverable and unrecoverable storage deal errors. Currently when a PublishStorageDeals message fails for any reason, all deals published in the message are destroyed by Lotus, even when only one deal in the message has caused an error (such as insufficient DataCap). Deals and data are lost unnecessarily.

Unrecoverable errors -> StorageDealFailing -> StorageDealError
Potentially recoverable publishing errors -> perhaps transition to StorageDealPublishFailed and provide a 'storage-deals recover' and 'storage-deals cancel' command to allow the operator to push the deal back into the publish queue.

Automatically re-queueing and retrying publishing deals would be even better, but only where there is no chance of a loop of failing messages.

@jennijuju jennijuju added P3 P3: Might get resolved and removed P2 P2: Should be resolved labels Sep 21, 2021
@jennijuju jennijuju added this to the v1.13.0 milestone Sep 21, 2021
@jennijuju
Copy link
Member

ideally lotus should do #7368 by default

and then give the option for a manual retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment