Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV13/Simulation] Log and/or Store failed messages #6409

Closed
Stebalien opened this issue Jun 7, 2021 · 1 comment
Closed

[NV13/Simulation] Log and/or Store failed messages #6409

Stebalien opened this issue Jun 7, 2021 · 1 comment

Comments

@Stebalien
Copy link
Member

Stebalien commented Jun 7, 2021

Simulation branch: #6406

Currently, we log when a message fails but it can be difficult to figure out what the exact message was. Whenever a message fails, we should log enough information to replicate the failure:

  1. The current height, parent tipset, and parent state.
  2. The number of previously applied messages.

We could also consider logging this in a big batch of "failed messages" after computing a tipset? But that may not be necessary.

@Stebalien
Copy link
Member Author

This is now such a low priority it's no longer worth tracking. The bug we were investigating has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants