You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The lotus binary can only built for a single network. This fact complicates lotus distribution and or limits the ability to join other networks when binaries are installed through a distributed package.
1-click digitalocean images are only usable on mainnet, even though it would be useful for people to be able to use the image to develop new applications.
1-click amazon AMIs require multiple images for the same code version.
Pre-built binaries would only work for one network.
Lotus availability through package managers (oh, snap! #6202) would only work for a single networks.
Describe the solution you'd like
We can simplify the process of building and distributing packages and ease a little of the pain for daap developers by using the same binary to run on multiple networks. Prior art can be seen everywhere, for example:
geth --networkid value
bitcoin-qt -testnet
CHIA_ROOT="~/.chia/testnet" chia start all
I suspect we can do this easily by implementing getters for network parameters.I wrote a proof-of-concept PR here #6354 . This PR removes various build flags used for building different networks, unexports the const parameters, and re-exports a NetworkParams object with getters for those same params. In this implementation, the network is selected based on an environment variable, which seems reasonable to me, but it could be implemented with a command-line flag instead if there is a preference for that.
Describe alternatives you've considered
Alternatively, network parameters could be passed by configuration file
Additional context
The text was updated successfully, but these errors were encountered:
@coryschwartz : I assigned this issue to you and put on the board. In light of the new direction we're moving to for Filecoin/Lotus reviews, can you get your PR reviewed by someone else on your team before we block waiting for a maintainer?
Is your feature request related to a problem? Please describe.
The lotus binary can only built for a single network. This fact complicates lotus distribution and or limits the ability to join other networks when binaries are installed through a distributed package.
Describe the solution you'd like
We can simplify the process of building and distributing packages and ease a little of the pain for daap developers by using the same binary to run on multiple networks. Prior art can be seen everywhere, for example:
geth --networkid value
bitcoin-qt -testnet
CHIA_ROOT="~/.chia/testnet" chia start all
I suspect we can do this easily by implementing getters for network parameters.I wrote a proof-of-concept PR here #6354 . This PR removes various build flags used for building different networks, unexports the const parameters, and re-exports a NetworkParams object with getters for those same params. In this implementation, the network is selected based on an environment variable, which seems reasonable to me, but it could be implemented with a command-line flag instead if there is a preference for that.
Describe alternatives you've considered
Alternatively, network parameters could be passed by configuration file
Additional context
The text was updated successfully, but these errors were encountered: