Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deal Making Issue] MaxSealingSectorsForDeals settings are ignored resulting in deals that crash the miner #6224

Closed
dkkapur opened this issue May 10, 2021 · 3 comments

Comments

@dkkapur
Copy link
Contributor

dkkapur commented May 10, 2021

Describe the problem

For storage deals being made from the miner side, even if the MaxSealingSectorsForDeals should be enforced as the miner is at a maximum, a deal is attempted resulting in a crash.

A deal should be automatically rejected if the miner is at capacity.

Version

Last reported around v1.5, v1.6.

@dkkapur
Copy link
Contributor Author

dkkapur commented May 10, 2021

@kernelogic - filed this per your note in Slack a few weeks ago. If you have any additional logs or details on a repro, please do share. Thanks!

@dkkapur dkkapur added this to the 🤝 Deal Success milestone May 10, 2021
@dkkapur dkkapur added the P2 P2: Should be resolved label May 10, 2021
@magik6k
Copy link
Contributor

magik6k commented May 17, 2021

#6041 is rewriting some related logic, worth checking if this was addressed there

@jennijuju jennijuju removed this from the 🤝 Deal Success milestone Mar 3, 2022
@TippyFlitsUK
Copy link
Contributor

Hi 👋

The Legacy Lotus Markets sub-system reached EOL at the end of the 31st January 2023.

This ticket is being marked as won't fix and closed as the Lotus Team will no longer be making any further fixes or enhancements to the legacy markets subsystem.

Please feel free to re-open this ticket in the new Boost markets sub-system repository at https://github.com/filecoin-project/boost if you feel that it is still relevant.

Many thanks 🙏

@TippyFlitsUK TippyFlitsUK added status/won't fix and removed P2 P2: Should be resolved labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants