Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestTimedBSSimple random failure #4482

Closed
Kubuxu opened this issue Oct 19, 2020 · 0 comments · Fixed by #4561
Closed

TestTimedBSSimple random failure #4482

Kubuxu opened this issue Oct 19, 2020 · 0 comments · Fixed by #4561
Labels
impact/test-flakiness Impact: Test Flakiness

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 19, 2020 

TestTimedBSSimple - github.com/filecoin-project/lotus/lib/timedbs

Failed
=== RUN   TestTimedBSSimple
    timedbs_test.go:73: 
        	Error Trace:	timedbs_test.go:73
        	Error:      	Should be true
        	Test:       	TestTimedBSSimple
--- FAIL: TestTimedBSSimple (0.03s)

@Stebalien we should probably use faked time for the test
@Kubuxu Kubuxu added the impact/test-flakiness Impact: Test Flakiness label Oct 19, 2020
@Kubuxu Kubuxu linked a pull request Oct 23, 2020 that will close this issue
Fix flaky TestTimedBSSimple #4561
Merged
@Kubuxu Kubuxu closed this as completed Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/test-flakiness Impact: Test Flakiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky TestTimedBSSimple filecoin-project/lotus
1 participant
@Kubuxu