chore: update go-car dependency #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TestRestartClient/ClientEventDealPublished is failing in CI and has been failing locally for me, even prior to this change, I don't have background on that and whether it's an expected flaky or not but I don't believe it's related to this. |
6 tasks
hannahhoward
approved these changes
May 11, 2022
|
honestly don't worry about the test failure. though wow we should really get our circle updated so we can at least run tests. Eek! |
|
I'm just gonna invoke those sweet admin privileges and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #639
Ref: ipld/go-car#254
Backstory: once upon a time, go-car had a branch that was used here to act as a filestore, but that branch was never merged to master. Over time, go-fil-markets evolved away from that particular usage of go-car, eventually making it disappear entirely in favour of go-car/v2.
ipld/go-car#254 documents attempts to get rid of this branch for good.
#639 was a previous attempt to start removing this branch dependency here.
The last update to the go-car dependency here was #653 which just replaced the branch ref with the latest master, which worked fine because by that time the use of the filestore and need for zero==eof was redundant.
So now we're just moving to a tagged version here and ticking off an item back in ipld/go-car#254
.