Update to unified graphsync v0.9.0 #615
Conversation
hannahhoward
requested review from
dirkmc and
aarshkshah1992
and removed request for
dirkmc
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 65.36% 65.27% -0.08%
==========================================
Files 62 62
Lines 4459 4459
==========================================
- Hits 2914 2910 -4
- Misses 1264 1268 +4
Partials 281 281
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This seems like simple interface change adaptation. LGTM, but @aarshkshah1992 and @dirkmc should sign off too.
| @@ -27,7 +27,7 @@ commands: | |||
| condition: << parameters.linux >> | |||
| steps: | |||
| - run: sudo apt-get update | |||
| - run: sudo apt-get install ocl-icd-opencl-dev | |||
There was a problem hiding this comment.
Why is this needed now? Is it due to the FFI upgrade?
There was a problem hiding this comment.
turned out didn't need ffi update so removed
There was a problem hiding this comment.
just kidding now I remember I had to do this in order to compile the FFI for M1 :(
go.mod
Outdated
| github.com/filecoin-project/go-ds-versioning v0.1.0 | ||
| github.com/filecoin-project/go-fil-commcid v0.1.0 | ||
| github.com/filecoin-project/go-fil-commp-hashhash v0.1.0 | ||
| github.com/filecoin-project/go-multistore v0.0.3 | ||
| github.com/filecoin-project/go-multistore v0.0.4-0.20210601185713-428a2691a567 |
There was a problem hiding this comment.
Yeah we should definitely get rid of this.
go.mod
Outdated
| @@ -7,11 +7,11 @@ require ( | |||
| github.com/filecoin-project/go-address v0.0.5 | |||
| github.com/filecoin-project/go-cbor-util v0.0.0-20191219014500-08c40a1e63a2 | |||
| github.com/filecoin-project/go-commp-utils v0.1.1-0.20210427191551-70bf140d31c7 | |||
| github.com/filecoin-project/go-data-transfer v1.7.6 | |||
| github.com/filecoin-project/go-data-transfer v1.7.8-0.20210827051445-c354689456a5 | |||
There was a problem hiding this comment.
Flagging that this should change to go-data-transfer v1.8.0 when the corresponding PR is merged and released upstream.
hannahhoward
force-pushed
the
feat/update-graphsync-v0.9.0
branch
3 times, most recently
from
cae978c to
79056fd
Compare
hannahhoward
force-pushed
the
feat/update-graphsync-v0.9.0
branch
from
79056fd to
9cea3e7
Compare
Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
hannahhoward
force-pushed
the
feat/update-graphsync-v0.9.0
branch
from
9cea3e7 to
79c52b7
Compare
Goals
This is based on #552, but rebased on master and updated to go-graphsync v0.9.0 which incorporates all the changes from the v0.6.x branch. It is part of the effort to unify graphsync versions post M1
Blocked by: