Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll Provider for acceptance only till (deal start epoch + grace period) has elapsed #516

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

aarshkshah1992
Copy link
Collaborator

Closes #503.

@aarshkshah1992 aarshkshah1992 requested a review from dirkmc March 25, 2021 09:40
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

(two small nits)

storagemarket/impl/clientstates/client_states.go Outdated Show resolved Hide resolved
storagemarket/impl/clientstates/client_states.go Outdated Show resolved Hide resolved
@aarshkshah1992
Copy link
Collaborator Author

@dirkmc Have accepted your suggestions. Please merge this when you want to.

@dirkmc dirkmc merged commit 1203c12 into master Mar 30, 2021
@dirkmc dirkmc deleted the feat/503 branch March 30, 2021 11:53
@dirkmc dirkmc mentioned this pull request Mar 30, 2021
@s0nik42
Copy link

s0nik42 commented May 12, 2021

@jennijuju How can I know if this is implemented in a specific version of lotus ?

@dirkmc
Copy link
Contributor

dirkmc commented May 12, 2021

@s0nik42 this was included in release v1.2.4 which is in v1.9.0-rc3 of lotus:
https://github.com/filecoin-project/lotus/blob/v1.9.0-rc3/go.mod#L37

@s0nik42
Copy link

s0nik42 commented May 12, 2021

Thank you for pointing me to this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client should stop polling provider for deal acceptance after (deal start epoch + grace period) has elapsed
3 participants