Sync up DealState to match spec #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
approved these changes
Jan 21, 2020
| StorageDealFailing | ||
| StorageDealRecovering | ||
| StorageDealExpired | ||
| StorageDealNotFound | ||
|
|
||
| // Internal |
There was a problem hiding this comment.
^^ NB: These are all "internal" in the sense that they are not actually states that exist outside these markets. In any case, I don't see much difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename
DealStatetoStorageDealStatus, add the states from the spec, and map them as closely as possible to the oldDealStateenum.Notes
There are some unused states, and the provider and client states are not broken up according to the states in the spec (leaving some unused states). This will be addressed when we figure out what is going on with the state machines for the client and provider deals.
Resolves https://github.com/filecoin-project/go-storage-market/issues/21