Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry config: separate max open attempts from backoff factor #467

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Dec 9, 2020

This PR separates out the maximum number of attempts to open a stream from the exponential backoff factor (the multiplier used when calculating how long to backoff before attempting again).

Also consolidates some retry code used by the networking layers of both retrieval and storage mining into one place.

@dirkmc dirkmc requested a review from hannahhoward December 9, 2020 13:56
@codecov-io
Copy link

Codecov Report

Merging #467 (f3db88c) into master (aa8533f) will decrease coverage by 0.51%.
The diff coverage is 93.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   65.58%   65.08%   -0.50%     
==========================================
  Files          46       50       +4     
  Lines        3198     3218      +20     
==========================================
- Hits         2097     2094       -3     
- Misses        875      898      +23     
  Partials      226      226              
Impacted Files Coverage Δ
shared/retrystream.go 90.91% <90.91%> (ø)
retrievalmarket/network/libp2p_impl.go 85.37% <100.00%> (+4.73%) ⬆️
storagemarket/network/libp2p_impl.go 85.72% <100.00%> (ø)
shared/movekey.go 0.00% <0.00%> (ø)
shared/ready.go 0.00% <0.00%> (ø)
shared/selectors.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8533f...f3db88c. Read the comment docs.

@dirkmc dirkmc merged commit e0b858b into master Dec 17, 2020
@dirkmc dirkmc deleted the feat/retry-config branch December 17, 2020 09:51
@dirkmc dirkmc mentioned this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants