Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate go-commp-utils #452

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Integrate go-commp-utils #452

merged 4 commits into from
Nov 20, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 19, 2020

Fixes filecoin-project/lotus#4899

Note: Depends on changing the go-state-types version in go-commp-utils go.mod to match the one in go-fil-markets:
github.com/filecoin-project/go-state-types v0.0.0-20200928172055-2df22083d8ab

@dirkmc dirkmc force-pushed the refactor/integ-commp-util branch from b7b5503 to c516eea Compare November 19, 2020 16:13
@hannahhoward hannahhoward marked this pull request as ready for review November 19, 2020 23:55
@codecov-io
Copy link

Codecov Report

Merging #452 (87199e6) into master (9ab6adb) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   65.20%   65.01%   -0.18%     
==========================================
  Files          47       46       -1     
  Lines        3229     3152      -77     
==========================================
- Hits         2105     2049      -56     
+ Misses        880      871       -9     
+ Partials      244      232      -12     
Impacted Files Coverage Δ
retrievalmarket/impl/provider_environments.go 63.64% <ø> (ø)
storagemarket/impl/client.go 20.16% <ø> (ø)
storagemarket/impl/clientutils/clientutils.go 40.00% <ø> (ø)
storagemarket/impl/provider.go 27.41% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab6adb...87199e6. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hannahhoward hannahhoward merged commit 68ed456 into master Nov 20, 2020
@dirkmc dirkmc deleted the refactor/integ-commp-util branch November 20, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Lotus CommP writer and use when calculating CommP in markets
3 participants