Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup project imports #327

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Cleanup project imports #327

merged 5 commits into from
Jul 20, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Standard imports formatting, which has drifted a lot

Implementation

Universal import formatting is:

  • standard packages

  • 3rd party packages

  • filecoin-project packages (not fil-markets)

  • fil-markets packages

  • script to run all this for the whole directory

  • CI step

  • makefile tasks

@codecov-commenter
Copy link

Codecov Report

Merging #327 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   63.01%   63.44%   +0.43%     
==========================================
  Files          40       40              
  Lines        2419     2472      +53     
==========================================
+ Hits         1524     1568      +44     
- Misses        788      793       +5     
- Partials      107      111       +4     
Impacted Files Coverage Δ
pieceio/pieceio.go 81.97% <ø> (ø)
piecestore/piecestore.go 82.76% <ø> (+2.76%) ⬆️
retrievalmarket/impl/client.go 71.55% <ø> (ø)
retrievalmarket/impl/clientstates/client_fsm.go 79.35% <ø> (ø)
retrievalmarket/impl/clientstates/client_states.go 94.03% <ø> (ø)
retrievalmarket/impl/dtutils/dtutils.go 76.57% <ø> (ø)
retrievalmarket/impl/provider.go 74.57% <ø> (ø)
retrievalmarket/impl/provider_environments.go 72.89% <ø> (ø)
...ievalmarket/impl/providerstates/provider_states.go 100.00% <ø> (ø)
...market/impl/requestvalidation/requestvalidation.go 92.73% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4d854...93f8cb7. Read the comment docs.

Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So satisfying.

Comment on lines +4 to +7
:1
$!N
s/\n\n/\'$'\n''/
/)/!b1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take your word for it.

Copy link
Collaborator Author

@hannahhoward hannahhoward Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't take my word, take the word of our wayward comrade @laser who I cribbed most of this from.

@hannahhoward hannahhoward merged commit 026a533 into master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants