-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup project imports #327
Conversation
remove two unneccesary steps
Setup make tasks for imports and other PR checks, add circle check on imports
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 63.01% 63.44% +0.43%
==========================================
Files 40 40
Lines 2419 2472 +53
==========================================
+ Hits 1524 1568 +44
- Misses 788 793 +5
- Partials 107 111 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So satisfying.
:1 | ||
$!N | ||
s/\n\n/\'$'\n''/ | ||
/)/!b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take your word for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't take my word, take the word of our wayward comrade @laser who I cribbed most of this from.
Goals
Standard imports formatting, which has drifted a lot
Implementation
Universal import formatting is:
standard packages
3rd party packages
filecoin-project packages (not fil-markets)
fil-markets packages
script to run all this for the whole directory
CI step
makefile tasks