Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect/tag libp2p connections during data transfer #316

Closed
wants to merge 2 commits into from

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Jul 6, 2020

Problem

Connection/peer tagging was removed in a previous commit, but it is needed to prevent connections from being recycled.

Summary

Add peer tagging during data transfer in both the client and provider FSMs.

@codecov-commenter
Copy link

Codecov Report

Merging #316 into master will decrease coverage by 0.27%.
The diff coverage is 27.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   63.75%   63.48%   -0.26%     
==========================================
  Files          41       41              
  Lines        2590     2604      +14     
==========================================
+ Hits         1651     1653       +2     
- Misses        818      829      +11     
- Partials      121      122       +1     
Impacted Files Coverage Δ
storagemarket/impl/client.go 3.15% <0.00%> (-0.05%) ⬇️
storagemarket/impl/provider.go 4.35% <0.00%> (-0.05%) ⬇️
storagemarket/network/deal_stream.go 63.16% <ø> (+10.99%) ⬆️
storagemarket/network/libp2p_impl.go 73.02% <0.00%> (-4.95%) ⬇️
storagemarket/impl/clientstates/client_states.go 89.44% <66.67%> (-0.56%) ⬇️
...oragemarket/impl/providerstates/provider_states.go 87.87% <100.00%> (+0.18%) ⬆️
retrievalmarket/impl/blockio/traverser.go 68.89% <0.00%> (-3.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca8089...bd0fa1d. Read the comment docs.

@ingar
Copy link
Contributor Author

ingar commented Jul 8, 2020

Closing in favor of filecoin-project/go-data-transfer#55

@ingar ingar closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants