-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use addresses from miner info for connecting to miners #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ncie
@hannahhoward i'm not exactly sure what the right way to get tests passing here is, any thoughts? |
@whyrusleeping submitted PR to this branch to get tests to pass. Note: this does not make the integration tests actually test the functionality you've implemented. To do that you'd need to actually configure functionality to make a real second peer id (on libp2p mocknet) that the miner could listen on. |
Another question: in this scenario, is the miner running seperate |
@whyrusleeping @magik6k this is somewhat blocking us to test an end-ot-end offline deal with dumbodrop. Is there something preventing a merge this week? /cc @mikeal |
@ribasushi I was waiting for @whyrusleeping to merge #291 which gets test passing. I am going to assume he's got other things happening and I'll take this home today. |
Provide a real response to GetMinerInfo so that integration tests pass
fix problems from rebase and add a few doc things
d2e4dda
to
34adcc4
Compare
@ribasushi this is ready for merge now from my point of view, but I don't know if you want to get confirmation from @whyrusleeping or @magik6k |
(I went ahead and did the rebase) |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 61.77% 61.55% -0.21%
==========================================
Files 41 41
Lines 2563 2572 +9
==========================================
Hits 1583 1583
- Misses 852 861 +9
Partials 128 128
Continue to review full report at Codecov.
|
* use addresses from miner info for connecting to miners * fix(storagemarket): fix integration test harness (#291) Provide a real response to GetMinerInfo so that integration tests pass * fix(storagemarket): fix rebase issues fix problems from rebase and add a few doc things Co-authored-by: Hannah Howard <[email protected]>
Not quite complete as i havent gotten the tests to pass yet, but this is most of the work.