Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test fix #28

Merged
merged 6 commits into from
Jan 10, 2020
Merged

Flaky test fix #28

merged 6 commits into from
Jan 10, 2020

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Jan 9, 2020

delete the tests

@shannonwells shannonwells changed the title attempt flaky test fix Flaky test fix Jan 9, 2020
@shannonwells shannonwells marked this pull request as ready for review January 9, 2020 23:27
@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #28 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage    14.8%   14.69%   -0.12%     
==========================================
  Files          26       26              
  Lines        1756     1756              
==========================================
- Hits          260      258       -2     
- Misses       1447     1448       +1     
- Partials       49       50       +1
Impacted Files Coverage Δ
retrievalmarket/network/deal_stream.go 70.83% <0%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14f645...1ee7279. Read the comment docs.

@shannonwells shannonwells force-pushed the bug/flaky-querystreamtest branch from 1e4c5e4 to 4034262 Compare January 9, 2020 23:30
@shannonwells shannonwells requested a review from ingar January 9, 2020 23:31
@hannahhoward
Copy link
Collaborator

so we can make a decision to delete these tests, but as written, I'd assert these aren't testing anything any more. Once the go routine is there, the test just finishes before the statements inside the go routine are done. Perhaps there is just no way to make it work and we should delete these tests. clearly, out of order reads do not work :)

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just delete these tests at this point, because while this fixes it, I don't believe anything is being testing because the test just finishes before anything in the go routine runs.

@shannonwells shannonwells requested review from hannahhoward and removed request for ingar January 10, 2020 00:47
@hannahhoward hannahhoward merged commit 31e8770 into master Jan 10, 2020
@shannonwells shannonwells deleted the bug/flaky-querystreamtest branch January 10, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants