-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test fix #28
Flaky test fix #28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 14.8% 14.69% -0.12%
==========================================
Files 26 26
Lines 1756 1756
==========================================
- Hits 260 258 -2
- Misses 1447 1448 +1
- Partials 49 50 +1
Continue to review full report at Codecov.
|
1e4c5e4
to
4034262
Compare
so we can make a decision to delete these tests, but as written, I'd assert these aren't testing anything any more. Once the go routine is there, the test just finishes before the statements inside the go routine are done. Perhaps there is just no way to make it work and we should delete these tests. clearly, out of order reads do not work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather just delete these tests at this point, because while this fixes it, I don't believe anything is being testing because the test just finishes before anything in the go routine runs.
delete the tests