-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/module docs #83 #267
Feat/module docs #83 #267
Conversation
Add description for ValidatePublishedDeal, adjust some links
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 64.86% 64.86%
=======================================
Files 40 40
Lines 2342 2342
=======================================
Hits 1519 1519
Misses 699 699
Partials 124 124 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting these comments early even though it's not ready for review:
Generally the storage & retrieval modules are headed in the right direction, and I just have some suggestions for additional information.
I'm also going to tag @mishmosh on this as someone with experience in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes address all of my comments, thanks! Please wait for @hannahhoward’s green check too before merging though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a handful of slight changes that might clarify things, and some syntactical nits.
Co-authored-by: Ingar Shu <[email protected]>
Co-authored-by: Ingar Shu <[email protected]>
Co-authored-by: Ingar Shu <[email protected]>
Co-authored-by: Ingar Shu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, THIS PR IS AWESOME. LGTM++++
The `filestore` module is a simple wrapper for os.File. It is used by [pieceio](../pieceio), | ||
[retrievialmarket](../retrievalmarket), and [storagemarket](../storagemarket). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would add the following:
The `filestore` module is a simple wrapper for os.File. It is used by [pieceio](../pieceio), | |
[retrievialmarket](../retrievalmarket), and [storagemarket](../storagemarket). | |
The `filestore` module is a simple wrapper for os.File. It's primary purpose to wrap a specific local directory configured by the node. It is used by [pieceio](../pieceio), | |
[retrievialmarket](../retrievalmarket), and [storagemarket](../storagemarket). |
Documentation pass for modules in this repo.
Request
I would appreciate feedback or even better, more detailed content on the storagemarket module since I don't know it as well as retrieval.