Storage Market Changes Based On Lotus Integration #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
approved these changes
May 5, 2020
| } | ||
|
|
||
| return ctx.Trigger(storagemarket.ProviderEventDealPublishError, xerrors.Errorf("PublishStorageDeals exit code: %w", code)) | ||
| if err := environment.Disconnect(deal.ProposalCid); err != nil { |
There was a problem hiding this comment.
I'm curious about Disconnect. Why is Disconnect called only when is no error? Also, there is a Disconnect call in SendSignedResponse, although in the tests it shows that it's harmless to do it twice.
There was a problem hiding this comment.
Disconnect gets called in the DealFailing handler, so no need to call it here. It probably should not be calling disconnect in SendSignedResponse and I will check that and add a ticket if needed.
update go-ipfs-ds-help and go-ipfs-blockstore to match lotus
Modify WaitForMessage signature -- as it turns out, we cannot wait for messages with confidences, only state changes (for the most part)
add a context to WaitForMessage since generally wait apis on node expect a context
hannahhoward
force-pushed
the
feat/lotus-integration-test
branch
from
55a1998 to
1738687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Get the latest go-fil-markets integrated with lotus so we can cut a 0.2.0 branch
Implementation
The integration revealed we can't as it turns out, wait with confidence on a chain message, only a state change -- we could technically call StateGetReceipt or StateSearchMessage -- but this would likely be extremely slow :(
So, in the absence, I removed confidence for now.
Also, our callback takes an exit code and data, but does not account for the possibility that the wait call itself errors (i.e. message was never posted). So I added third error parameter to the callback to capture this.
I also added a context to the call (LOTUS and I imagine GFC API expect a context), and made a few dependency updates