-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storagemarket/provider allows subscription to events #202
Storagemarket/provider allows subscription to events #202
Conversation
|
||
// ------- | ||
// providerDealEnvironment | ||
// ------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept paging too far down looking at stuff, so I figured a comment might help
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 67.88% 67.15% -0.73%
==========================================
Files 40 40
Lines 2117 2161 +44
==========================================
+ Hits 1437 1451 +14
- Misses 573 601 +28
- Partials 107 109 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove go routine and fix test
Convert providerSubscriber to take a MinerDeal value, not a reference. Passing the whole deal is correct but should not be a pointer.
e128c68
to
fe99358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and that's a really good test for state flow.
} | ||
} | ||
|
||
expectedStates := []storagemarket.StorageDealStatus{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this check!
WAT
closes #77
HAO
Questions
I'm sending the entire deal to the subscriber. Not sure if that's what we really want though.