Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple peers per payloadCID #197

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Conversation

shannonwells
Copy link
Contributor

Closes #101

Amend storage record of payloadCIDs to store a list of retrieval peers instead of just one.

@codecov-io
Copy link

Codecov Report

Merging #197 into master will decrease coverage by 0.34%.
The diff coverage is 68.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   68.13%   67.79%   -0.33%     
==========================================
  Files          39       41       +2     
  Lines        2108     2139      +31     
==========================================
+ Hits         1436     1450      +14     
- Misses        569      578       +9     
- Partials      103      111       +8     
Impacted Files Coverage Δ
retrievalmarket/discovery/local.go 60.98% <68.97%> (ø)
storagemarket/network/ask_stream.go 50.00% <0.00%> (-16.66%) ⬇️
retrievalmarket/impl/blockio/traverser.go 70.24% <0.00%> (-3.57%) ⬇️
retrievalmarket/discovery/discovery.go 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4378bd4...3484aec. Read the comment docs.

return l.ds.Put(key, newRecord)
}

func hasPeer(peerList []retrievalmarket.RetrievalPeer, peer retrievalmarket.RetrievalPeer) bool {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these are going to be relatively short lists.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea shouldn't be too bad

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shannonwells shannonwells force-pushed the feat/multiplePeers-#101 branch from 3484aec to 74b79d7 Compare April 21, 2020 23:12
@shannonwells shannonwells merged commit ff4afc5 into master Apr 21, 2020
@shannonwells shannonwells deleted the feat/multiplePeers-#101 branch April 21, 2020 23:18
@dirkmc dirkmc mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track multiple Retrieval Peers
3 participants