Handle self-retrieval correctly #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the case of retrieval from one's one node, payment vouchers are already saved, indicating a received delta of zero -- in this case, instead of reading the delta, inspect the actual voucher amount difference from funds received
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Allow self-deal retrievals to complete
Implementation
In the case of retrieving data that one stored with one's own storage mining node, the wallet addresses are the same, and payment vouchers are already saved. As a result, saving the payment voucher succeeds but returns a value of 0 for the delta between the voucher and the last voucher saved. In this case, we can fall back to examining the actual voucher amount and subtracting from the funds received to verify the actual delta. This allows retrieval deals to complete.
This has actually been broken for some time, but it only became apparent when a recent change to the retrieval market forced the client to actually confirm it's last payment was accepted -- prior to that tests passed in Lotus even though the deal actually failed, cause the client considered the deal complete as soon as it sent the last payment, even if the provider was unable to process it.