Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to coalesce distinct pubsub messages #601

Open
Stebalien opened this issue Aug 28, 2024 · 2 comments
Open

Make it possible to coalesce distinct pubsub messages #601

Stebalien opened this issue Aug 28, 2024 · 2 comments
Labels

Comments

@Stebalien
Copy link
Member

If we split pubsub message IDs into "validation IDs" and "propagation IDs", we'll be able to drop equivalent pubsub messages even if they're not 100% identical.

  • At the validation layer, use the message hash to deduplicate (make sure to make this work with rebroadcast).
  • After successful validation, identify the message based on the hash of the gpbft value.
  • Only propagate messages with unique GPBFT values.
@Stebalien
Copy link
Member Author

Stebalien commented Aug 30, 2024

IIRC, there were two motivations here:

  1. An improved finality certificate protocol. But that can always be punted till later.
  2. Avoiding justification validation. Given Change BLS signature/public key aggregation to enable better caching #592, I'm not sure if that's still critical. Validation of justification signatures is just as fast as validating the message so, at most, we'd cut validation time by 1/2 (but I'm not sure if that's worth it, also Batch validate justification + message signature #614).

@Stebalien
Copy link
Member Author

We're deferring this because it's not a huge priority, see above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant