Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve events #52

Merged
merged 1 commit into from
May 6, 2020
Merged

Improve events #52

merged 1 commit into from
May 6, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Achieve parity on both sides for a minimum set of data transfer events: Open and Close

Implementation

  • add open events to both initiator and responder
  • fix an error where an error event was dispatched on the initiator side of a Push request

@hannahhoward hannahhoward force-pushed the feat/improve-events branch from 9a743ad to 24ff6f0 Compare May 5, 2020 23:26
@hannahhoward hannahhoward requested review from shannonwells and ingar May 5, 2020 23:26
ingar
ingar approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the quick turnaround..

@hannahhoward
feat(graphsyncimpl): fix open/close events
8348183 
Remove error on push acceptance, make both sides have open events
@hannahhoward hannahhoward force-pushed the feat/improve-events branch from 24ff6f0 to 8348183 Compare May 6, 2020 19:06
@hannahhoward hannahhoward merged commit a74d66b into master May 6, 2020
@rvagg rvagg deleted the feat/improve-events branch January 5, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingar ingar ingar approved these changes

@shannonwells shannonwells Awaiting requested review from shannonwells

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @ingar