Fix parallel transfers between same two peers #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the parallel transfer test to fix the issues that made the test ineffective and then update go-graphsync to fix the actual issue
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 68.00% 67.93% -0.07%
==========================================
Files 24 24
Lines 3069 3069
==========================================
- Hits 2087 2085 -2
- Misses 627 629 +2
Partials 355 355
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
HAT TIP @tchardin !!! You may have caught a fairly critical bug.
Your bug report and submitted test revealed a serious issue in the go-graphsync responder implementation.
Implementation
This PR contains some fixes to @tchardin 's test to insure it properly catches the issue in question, and then an update to go-graphsync (ipfs/go-graphsync#211) that fixes the issue.