limit consecutive restarts with no data transfer #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
feat/limit-consec-restarts
branch
from
29173b1 to
cb9fa71
Compare
3 tasks
nonsense
reviewed
Dec 18, 2020
nonsense
approved these changes
Dec 18, 2020
dirkmc
force-pushed
the
feat/limit-consec-restarts
branch
from
cb9fa71 to
fc47495
Compare
This was referenced Dec 18, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for filecoin-project/lotus#5211
Currently when a push channel stalls (no data is sent for a while) the push channel monitor will attempt to restart the channel.
It's possible that the monitor will keep restarting the channel forever, and the transfer will get stuck.
This PR adds a configurable parameter
maxConsecutiveRestarts- the maximum number of restarts in a row to attempt where no data is transferred. When the limit is reached the channel is closed.