-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmarshall Undef state for ChannelID #143
Comments
This was referenced Feb 12, 2021
Fixed by filecoin-project/go-fil-markets#490 |
Not able to run the command to list retrieval deals:
|
Closing this issue in favour of tracking the issue in the lotus repo: filecoin-project/lotus#4437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when a provider receives a request for retrieval, the provider creates a ProviderDealState with an undefined data transfer ChannelID. Once the deal is accepted, a data transfer channel is created and the ChannelID is set on the ProviderDealState.
If the deal state is accessed before the data transfer has started (this can happen coincidentally, or if the deal state is accessed for a deal that was not accepted), the deal state fails unmarshalling because it's not possible to Unmarshall a ChannelID that has not been defined.
References to the ChannelID field should be pointers so that they are initially nil, and set to a value once the data transfer has started.
This change should be made for both the
ClientDealState
andProviderDealState
Example: filecoin-project/lotus#5409 (comment)
The text was updated successfully, but these errors were encountered: