Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market actor: Minor improvements to exported getters #825

Closed
arajasek opened this issue Nov 9, 2022 · 0 comments
Closed

Market actor: Minor improvements to exported getters #825

arajasek opened this issue Nov 9, 2022 · 0 comments
Assignees
@arajasek
Labels
P1
Milestone
Reenginering buil...

Comments

@arajasek
Copy link
Contributor

arajasek commented Nov 9, 2022 •
edited
Loading

  • GetDealTermExported: Return (start_epoch, duration) instead of (start_epoch, end_epoch). This is potentially closer to what other market designs want (and end_epoch can be derived from duration).

  • GetDealEpochPriceExported: Return the deal's total price instead of per-epoch price.
@arajasek arajasek changed the title Market actor: GetDealTermExported: Return (start_epoch, duration) Market actor: Minor improvements to exported getters Nov 9, 2022
@arajasek arajasek mentioned this issue Nov 9, 2022
Merged
@jennijuju jennijuju moved this to 📋 Backlog in Network v18 Nov 25, 2022
@jennijuju jennijuju added the P1 label Nov 25, 2022
@anorth anorth moved this from 📋 Backlog to 🏗 In progress in Network v18 Dec 5, 2022
@arajasek arajasek moved this from 🏗 In progress to ✅ Done in Network v18 Dec 16, 2022
@anorth anorth closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arajasek arajasek

Labels
P1
Projects
No open projects
Network v18
Status: ✅ Done
Milestone
Reenginering built-in actors API
Development

No branches or pull requests
3 participants
@anorth @arajasek @jennijuju