Add ALL_PROXY and NO_PROXY to collected env_vars

Resolves: sosreport#3788 Signed-off-by: Pablo Fernández Rodríguez<[email protected]> Signed-off-by: Pablo Fernández Rodríguez <[email protected]>
filanov · Nov 24, 2024 · 88012ef · 88012ef
1 parent 6645b1e
commit 88012ef
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/sos/report/plugins/foreman.py b/sos/report/plugins/foreman.py
@@ -297,7 +297,12 @@ def collect_proxies(self):
                                         timeout=10)
 
         # collect http[|s]_proxy env.variables
-        self.add_env_var(["http_proxy", "https_proxy"])
+        self.add_env_var([
+            'HTTP_PROXY',
+            'HTTPS_PROXY',
+            'NO_PROXY',
+            'ALL_PROXY',
+        ])
 
     def build_query_cmd(self, query, csv=False, binary="psql"):
         """

diff --git a/sos/report/plugins/foreman_proxy.py b/sos/report/plugins/foreman_proxy.py
@@ -42,7 +42,12 @@ def setup(self):
         ])
 
         # collect http[|s]_proxy env.variables
-        self.add_env_var(["http_proxy", "https_proxy"])
+        self.add_env_var([
+            'HTTP_PROXY',
+            'HTTPS_PROXY',
+            'NO_PROXY',
+            'ALL_PROXY',
+        ])
 
     def postproc(self):
         self.do_path_regex_sub(