Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant routes without prefix get precedence over app's web routes #14683

Open
mrmonat opened this issue Nov 1, 2024 · 0 comments
Open

Tenant routes without prefix get precedence over app's web routes #14683

mrmonat opened this issue Nov 1, 2024 · 0 comments
Labels

Comments

@mrmonat
Copy link

mrmonat commented Nov 1, 2024

Package

filament/filament

Package Version

v3.2.117

Laravel Version

11.27.2

Livewire Version

No response

PHP Version

PHP 8.3.0

Problem description

When using Multi-Tenancy in Combination with ->path('') (or ->path('/')) and without ->tenantRoutePrefix('xyz') Routes in routes/web.php and other Packages routes (for example /horizon from Laravel Horizon) result in a 404 not found error (or a redirect to /login if not logged in to filament).

// routes/web.php
return [
    Route::get('/test', function () { // Results in 404
        return "OK";
    }
];

Expected behavior

Filament's Routes should be registered after the Routes in web.php and after other Packages Routes.

Visiting /test should work, visiting /horizon should work.

Steps to reproduce

  • Fresh Installation
  • Enable Multi-Tenancy
  • Set ->path('') for the panel
  • Add /test Route in web.php
  • Open /test -> Results in 404

Reproduction repository (issue will be closed if this is not valid)

https://github.com/mrmonat/filament-issue

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@mrmonat mrmonat added bug Something isn't working medium priority unconfirmed labels Nov 1, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Nov 1, 2024
@mrmonat mrmonat changed the title Tenant routes without prefix get precedence over "app's web routes" Tenant routes without prefix get precedence over app's web routes Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant