Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not package the venv dir (reduce the installed size 200x) #35

Closed
ChALkeR opened this issue Feb 21, 2016 · 3 comments
Closed

Do not package the venv dir (reduce the installed size 200x) #35

ChALkeR opened this issue Feb 21, 2016 · 3 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 21, 2016

Your current npm package size is 33 MiB, and unpacked size is 168 MiB (as of [email protected]).

167 MiB of that is inside the venv directory.

It looks like stuff from that directory is not used by the package, so most probably it was packaged by an accident.

You could add it to .npmignore (if you have an .npmignore already) or to .gitignore (if you don't have an .npmignore), or use the files field in your package.json file.

Directory listing with sizes:

4,0K    diff-dom-2.0.0.tgz/bower.json
8,0K    diff-dom-2.0.0.tgz/demo
48K     diff-dom-2.0.0.tgz/diffDOM1.js
48K     diff-dom-2.0.0.tgz/diffDOM2.js
48K     diff-dom-2.0.0.tgz/diffDOM.js
4,0K    diff-dom-2.0.0.tgz/index.html
8,0K    diff-dom-2.0.0.tgz/LICENSE.txt
40K     diff-dom-2.0.0.tgz/newDiffDOM.js
28K     diff-dom-2.0.0.tgz/oldDiffDOM.js
4,0K    diff-dom-2.0.0.tgz/package.json
4,0K    diff-dom-2.0.0.tgz/README.md
40K     diff-dom-2.0.0.tgz/RecentDiffDOM.js
4,0K    diff-dom-2.0.0.tgz/test3.html
156K    diff-dom-2.0.0.tgz/test.html
296K    diff-dom-2.0.0.tgz/tests
167M    diff-dom-2.0.0.tgz/venv
@ChALkeR
Copy link
Author

ChALkeR commented Feb 21, 2016

Ref: nodejs/node#5230 (comment)

@ChALkeR
Copy link
Author

ChALkeR commented Feb 21, 2016

Things like diffDOM1.js, diffDOM2.js, newDiffDOM.js, oldDiffDOM.js, RecentDiffDOM.js also look a bit out of place.

@johanneswilm
Copy link
Member

@ChALkeR Thanks for pointing that out. I just assumed it would only take the git-controlled files. I have removed the files and added the .gitignore file in the 2.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants