-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with nodejs.sh #172
Comments
Hhmm, I've just had a look in the nodejs.sh file again, and I see that lines 34 - 42 actully do this re-sourcing - but this happens above the 65 - 80, which seem to do some more to the Should lined 34 - 42 be moved below 65 - 80, or should they maybe be duplicated? (Sorry, I don't have enough experience with this stuff to know what the right answer is) |
One more thing I've noticed -
I've got a feeling this has come from the NVM install script being referenced: https://gist.githubusercontent.com/Ilyes512/8335484/raw/nvm_install.sh |
I think we broke more than we fixed when we changed the |
Experiencing the same here. |
I could be thinking in totally the wrong direction here, but I think, because we probably want to keep using I'm just in the process of testing the other files which were edited to see if they've fallen over as well.... sorry guys, I think this is totally my fault. |
Good call, that external script needs updating. No fault, no worries. We're allowed to break stuff, it's open source! |
Paging @Ilyes512 :D |
Continuing my investigations, I've come across another error:
This one seems to be related to |
@fideloper would it not be better for @Ilyes512's script to be part of the Vaprobash repo? |
Since it's semi-specific to Vaprobash, I'm thinking that could be part of nvm.sh instead of separate, yes. |
Will look at it at home. At the gym right now :) |
Other than the additional issue with the No idea what's causing the rvm issue I'm sorry to say. |
@Ilyes512 Updating the @fideloper As I said before, I think this script should be part of the vaprobash repo, but I don't know within what context (i.e. should be be dumped, as is, into the middle of the I have the same question of the vhost script file: https://gist.githubusercontent.com/fideloper/2710970/raw/vhost.sh - rather than this script existing as a gist, an additional folder (called Doing something like this would allow for pull requests to be made on these files, and might help avoid issues such as the one we've had by changing all references from Still no idea how to fix the rvm issue, but am looking into it now. I did stumble upon this however: bryannielsen/Laravel4-Vagrant#20 - seems I've had exactly the same issue with another vagrant script. |
On it right now, should be fixed within the hour. I also think it's because of the gist, cause that was the last thing I changed (and didn't tested on later). Keep you posted! edit: edit2: |
Gotcha. sourcing |
I think I got it: |
Right - to be more accurate, I think another install script may have created |
Ok, nice to know. So does that mean one can assume .profile will always exist? (So no check needed for it?) edit: >>> Installing Node Version Manager
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1012 0 1012 0 0 371 0 --:--:-- 0:00:02 --:--:-- 601
Cloning into '/home/vagrant/.nvm'...
>>> Appending source string to /home/vagrant/.profile
sh: 32: [[: not found
>>> Installing Node.js version latest
This will also be set as the default node version
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6318 100 6318 0 0 8019 0 --:--:-- --:--:-- --:--:-- 18419
######################################################################## 100.0%
Now using node v0.10.26
default -> v0.10.26
Now using node v0.10.26
>>> Starting to config Node.js This line |
Right, Ubuntu 12.04 will always have .profile. On Sat, Mar 1, 2014 at 5:06 PM, Ilyes [email protected] wrote:
|
So it's working if your not using ZSH, but something goes wrong with this: # Check if .zshrc exist
if [[ -f "$ZSHRC" ]]; then
# Append NVM script to ~/.zshrc
if [[ ! grep -qsc 'nvm.sh' $ZSHRC ]]; then
echo ">>> Appending source string to $ZSHRC"
echo $SOURCE_STR >> "$ZSHRC"
else
echo ">>> Source string already in $ZSHRC"
fi
fi Somehow edit: |
Do we have any idea why the RVM stuff is still failing? I've never had much luck with Ruby or RVM, but I've tested the install procedure provided in the last message the following page in a vaprobash box, and it works fine: bryannielsen/Laravel4-Vagrant#20 Is it worth looking changing how RVM is installed? |
RVM is working again. It had to do with 2 things:
And about your link and the installation mentioned. It's nothing different then was happening now except for the error that was caused because of the above and 2 other differences.
I will run the current development branch and try and install guard to see if it's successfully installs it or not. edit: |
👍 |
Re: RVM, I'm still getting the same error as two days ago - #172 (comment) The issue appears to be related to this block of code in
The relevant section of my
|
I have been testing it yesterday and I had no luck installing |
I know very little about RVM, so can't pinpoint the exact point of failure, but if you think it's the installing of the gem which is failing, do you have any joy with Bundler (because that is what i think might be failing for me) Cheers :) |
Yeah, I tried it because of your link to this page: bryannielsen/Laravel4-Vagrant#20 And so I tried it out. I will test out installing |
I'm going to close this issue because the title doesn't match the current problem. A new ticket for the RVM issues is here: #185 |
I don't know if this is related to the change we made earlier (probably is mind you), but now when I run
vagrant up
I'm getting the following errors:which I've tracked down to being within the
nodejs.sh
file.I know that part of the script sets path info and some other bits, so I'm wondering if they need to be re-sourced (is that the correct term?) like they are in the
rvm.sh
file?The text was updated successfully, but these errors were encountered: