version 1.1.2 update #33
Conversation
Signed-off-by: Filip Michalsky <[email protected]>
| April, 15, 2021 1.11.2 | ||
| ------------------------------------------------------------------------------- | ||
| minor: | ||
| - Updated dtype from np.int to int in base_mab.py line 294 to resolve deprecation warning from numpy>=1.20.0 |
CHANGELOG.txt
Outdated
| ------------------------------------------------------------------------------- | ||
| minor: | ||
| - Updated dtype from np.int to int in base_mab.py line 294 to resolve deprecation warning from numpy>=1.20.0 | ||
| - Updated tests to reflect changes in KMeans update in sklearn>=0.24.0 |
There was a problem hiding this comment.
The change is to the sklearn version dependency, the unit tests are incidental to that. Suggested rephrasing: "Updated sklearn version dependency to >=0.24.0 because of changes in the KMeans implementation"
There was a problem hiding this comment.
thank you, updated.
There was a problem hiding this comment.
-
How many times are they gonna re-implement K-Means from scratch.... :D
-
This might then have an impact anywhere else we use K-Means (e.g, Content Selection..)
There was a problem hiding this comment.
@skadio I will check all other libraries as well
Signed-off-by: Filip Michalsky <[email protected]>
| @@ -1,6 +1,6 @@ | |||
| joblib | |||
| numpy | |||
| pandas | |||
| scikit-learn>=0.22.0 | |||
| scikit-learn>=0.24.0 | |||
There was a problem hiding this comment.
Not about this PR, but I am very curious how >= 0.24 will play with other libraries. It would be amazing if we can make a jump to the newer version, across the board.
version 1.1.2:
Signed-off-by: Filip Michalsky [email protected]