Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open clients note link in new tab #36

Open
anthony-robin opened this issue Jan 28, 2024 · 3 comments
Open

Open clients note link in new tab #36

anthony-robin opened this issue Jan 28, 2024 · 3 comments

Comments

@anthony-robin
Copy link

I often use njump to check how content is rendered on different client and loosing the current njump tab on clicking a client force to use back browser or redo the njump note id check to go to another client.

What would you think of adding a target="_blank" attribute to right sidebar client links when opening a content ? Maybe the new tab could be an HTML option that would toggle, on the fly, the target attribute on client list links ?

Thank you for building njump, very helpful and strong tool of everyday :)

@fiatjaf
Copy link
Owner

fiatjaf commented Jan 28, 2024

Two questions:

  1. Why don't you use the middle-click?
  2. Is it really bad to go back? The njump page should be heavily cached so if you go back it should load instantly.

@cxplay
Copy link
Contributor

cxplay commented Jan 29, 2024

I think you should copy the id of the event and then go to the client side to get the content of the event.

@anthony-robin
Copy link
Author

Thank you @fiatjaf

  1. Sure I could still use the middle click / right click -> open in new tab / pressing ctrl or cmd before clicking the link. My use case is more to be effective by closing with keyboard shortcut the client tab as soon as I checked the note and then expecting to go back to njump to verify the next one :)
  2. Not a big deal at all, njump is very quick to load !

Feel free to close the issue if you consider it is good as it is now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants