Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended kubernetes labels #134

Open
mortenlj opened this issue Nov 19, 2020 · 1 comment
Open

Use recommended kubernetes labels #134

mortenlj opened this issue Nov 19, 2020 · 1 comment

Comments

@mortenlj
Copy link
Member

There is a set of recommended labels that overlap to some degree with the labels we set. Should we transition to using the recommended labels instead of (or in addition to) the ones we set?

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

I think we at least could add these:

app.kubernetes.io/name: myapp
app.kubernetes.io/version: "5.7.21"
app.kubernetes.io/managed-by: fiaas

See also #9 for a related issue.

@oyvindio
Copy link
Member

I think it makes sense to add these to the list of managed labels. I think for example the app label is convenient and would prefer to keep that in addition to rather than replace it with app.kubernetes.io/name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants