Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

If available, use system pipework, else bundled. #372

Closed
wants to merge 1 commit into from
Closed

If available, use system pipework, else bundled. #372

wants to merge 1 commit into from

Conversation

rswarts
Copy link

@rswarts rswarts commented May 4, 2015

The bundled script is in the user's home directory. If pipework is on
the system, prefer using that over sudo-ing a user editable script.

The bundled script is in the user's home directory. If pipework is on
the system, prefer using that over sudo-ing a user editable script.
@fgrehm
Copy link
Owner

fgrehm commented May 8, 2015

I like this but unfortunately I don't have the time to test it. If someone else is able to do that and is interested on this functionality please 👍 this PR!

@fgrehm
Copy link
Owner

fgrehm commented Jul 16, 2015

Sorry for the long silence but as per GH-375 I'm looking for help to maintain this plugin and for now I'm holding back from bringing in new changes =/

If you are interested on maintaining the project and keep things moving please shoot me an email or drop a message on GH-375 so I can arrange things.

Cheers 🍻

@ghost
Copy link

ghost commented Dec 13, 2017

It's very true that sudoing pipework which is user-writable is a bad idea, but then again, the whole sudo wrapper thing is a bit on the "shaky" side of things, a necessary hack for darker times.

Now that unprivileged containers support is coming, the sudo wrapper will become legacy. If security is the only reason for this PR, might I suggest that we let it go?

@fgrehm
Copy link
Owner

fgrehm commented Dec 14, 2017

If pipework can be dropped I'm totally fine with that. And BTW, I think that and support for unprivileged containers deserves a nice 2.0 bump ;-)

@ghost
Copy link

ghost commented Dec 14, 2017

@fgrehm it's not that pipework could be dropped, but more that pipework could be called without sudo (rendering this PR useless). Its README seems to indicate that it's possible to create the bridge within the container.

@rswarts
Copy link
Author

rswarts commented Dec 14, 2017 via email

@ghost
Copy link

ghost commented Dec 14, 2017

trusty-backports has 2.0.8, so it should be possible

@fgrehm fgrehm added the ignored label Nov 17, 2022
@fgrehm
Copy link
Owner

fgrehm commented Nov 17, 2022

Hey, sorry for the silence here but this project is looking for maintainers 😅

As per #499, I've added the ignored label and will close this issue. Thanks for the interest in the project and LMK if you want to step up and take ownership of this project on that other issue 👋

@fgrehm fgrehm closed this Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants