fix rinkeby which is not used anymore #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgiannotti
commented
Oct 10, 2022
Comment on lines
+9
to
+15
| import fetch from 'node-fetch'; | ||
| import { abortableFetch } from 'abortcontroller-polyfill/dist/cjs-ponyfill'; | ||
| // To fix: https://github.com/node-fetch/node-fetch/issues/784 | ||
| // useful: https://www.npmjs.com/package/node-abort-controller, but I used this: https://lightrun.com/answers/apollographql-apollo-client-expected-signal-to-be-an-instanceof-abortsignal | ||
| global.fetch = abortableFetch(fetch).fetch; | ||
|
|
||
| declare const module: any; |
There was a problem hiding this comment.
Esto arregla un problema mío que me saltaba con un bug que tiene node-fetch. (node-fetch/node-fetch#784)
Algo de CONNECTION ERROR no se que, y por detrás debugeando muuucho encontre otro error escondido que es exactamente el que está en el issue) googleando un toque varios fix este me funcionó.
A todo esto Node-fetch lo solucionó ya. Pero no tenemos esa versión bajada (Y no podemos subirla porque es una dependencia que usa web3, no nosotros directamente)
francoarcu
approved these changes
Oct 10, 2022
SantiagoAspres
requested review from
SantiagoAspres
and removed request for
SantiagoAspres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Por el tema del 'The merge' con ethereum. Rinkeby está deprecada e infura no nos la deja usar mas, hay que usar goerli o sepolia.
Busque unos faucets y me dí tokens a la wallet 'nuestra' de metamask (la que está en las envs) e hice un par de transacciones y funcionaron.
Call.js funcionando:
Tmb desde el web server se arreglo