Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate derived_quantities, traps, exports etc #861

Open
RemDelaporteMathurin opened this issue Aug 2, 2024 · 0 comments
Open

Deprecate derived_quantities, traps, exports etc #861

RemDelaporteMathurin opened this issue Aug 2, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@RemDelaporteMathurin
Copy link
Collaborator

RemDelaporteMathurin commented Aug 2, 2024

Following #697 and other similar PRs we now have classes like DerivedQuantities, Traps etc inheriting from list.

We kept attributes like derived_quantities, traps, exports etc for backwards compatibility but it is time to remove them.

Example:

@property
def derived_quantities(self):
warnings.warn(
"The derived_quantities attribute will be deprecated in a future release, please use festim.DerivedQuantities as a list instead",
DeprecationWarning,
)
return self

@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Aug 2, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the 1.4 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant