Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace trap.id by trap.name and convert id argument to attribute #811

Open
KulaginVladimir opened this issue Jul 12, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@KulaginVladimir
Copy link
Collaborator

KulaginVladimir commented Jul 12, 2024

oh, yes. I just meant that, personally, I find convinient to define export for (and then access) traps with their ids. Though it might be a matter of taste.

Right, so i think we need to make a different between the index of the traps in the list (only used for constructing the function space) and the tag/name of the trap that is a user-friendly way of referring to it.

We can have users refer to a trap in for example exports by either using the actual trap object, or its name, or its index in the trap list.
We remove the id as a user-defined argument and just have it for convenience as an attribute (maybe).
Then we simply have to forbid users to use digits-only names.

Anyway we can merge this PR and ship the discussion elswehere

Originally posted by @RemDelaporteMathurin in #810 (comment)

@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Jul 12, 2024
@RemDelaporteMathurin RemDelaporteMathurin changed the title Trap reference Replace trap.id by trap.name and convert id argument to attribute Jul 29, 2024
@RemDelaporteMathurin RemDelaporteMathurin added this to the UKAEA workshop milestone Aug 1, 2024
@RemDelaporteMathurin RemDelaporteMathurin removed this from the UKAEA workshop milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants