Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units of export given in title #710

Closed
jhdark opened this issue Mar 19, 2024 · 1 comment · Fixed by #736
Closed

Units of export given in title #710

jhdark opened this issue Mar 19, 2024 · 1 comment · Fixed by #736
Labels
enhancement New feature or request
Milestone

Comments

@jhdark
Copy link
Collaborator

jhdark commented Mar 19, 2024

The unit of each export could be given in its respective doc strings. To take this further, the unit could be written in the title of each derived quantity and should be automatically generated depending on the dimension of the mesh

@jhdark jhdark added the enhancement New feature or request label Mar 19, 2024
@RemDelaporteMathurin
Copy link
Collaborator

This may be a breaking change since some users already look for the columns in the CSV without the units so we would have to be careful

@RemDelaporteMathurin RemDelaporteMathurin linked a pull request Mar 25, 2024 that will close this issue
10 tasks
@RemDelaporteMathurin RemDelaporteMathurin added this to the v1.3 milestone Mar 27, 2024
@RemDelaporteMathurin RemDelaporteMathurin linked a pull request Apr 5, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants