Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On connection error not handled on redis client. #2

Open
alexdobarganes opened this issue Feb 16, 2017 · 0 comments
Open

On connection error not handled on redis client. #2

alexdobarganes opened this issue Feb 16, 2017 · 0 comments

Comments

@alexdobarganes
Copy link
Contributor

Consider setting the listener this.client.on('error', function (err) { return; }); to avoid the error bubbling up and causing the app to die.

private connect(cb: (e: Error) => void) {
        this.client = redis.createClient(this.redisServer.port,this.redisServer.hostname);
        this.client.on('error', function (err) {
            return;
        });
        if(!_.isUndefined(this.redisServer.password)){
            this.client.auth(this.redisServer.password, (e) => {
                cb(e);
            });
        } else {
            cb(null);
        }
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant