Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of bounds on argument by for BitArray::shift_end and shift_start #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix documentation of bounds on argument by for BitArray::shift_end and shift_start #251

wants to merge 1 commit into from

Conversation

albertsgarde
Copy link

Fixes #250

I changed the assert message, but it might make more sense to change the assertion itself to by < len instead of by <= len, since we only run the assertion if by is not equal to len.

I am pretty certain the documentation change is correct.

@albertsgarde albertsgarde mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BitSlice::shift_start and BitSlice::shift_end argument bounds incorrectly documented
1 participant
@albertsgarde