-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport the recent security fix to 3.x #74
Comments
That would be great because simple-get ^3.0.3 is a transitive dependency of other packages, like prebuild-install v5 and v6. |
Looks like there is a backport for 2.x.x in PR #75 , I would surmise a fix here would be very similar. I hope we get some traction here. |
I think that you can already make your pull request @LinusU, so that feross just have to approve and merge the stuff. |
@LinusU I gave you access to this package on GitHub and npm to help handle these security fixes. Appreciate it! |
I've cherry-picked the fix and released |
Thanks! Somebody has poked the powers that be so GHSA-wpg7-2c88-r8xv get updated with the new fixed versions? |
Unfortunately I have no idea how to do that, would love to get to know how though |
Amazing, thanks. For the record: the last version number is a typo and needs to be 2.8.2. See also versions tab in https://www.npmjs.com/package/simple-get. |
We are using version 3.x of
simple-get
incanvas
and cannot upgrade to 4.x without making it a breaking change since we still support Node.js 6.x.@feross would it be possible to have the patch back ported to the 3.x release line?
I can submit a PR if you create a
3.x
branch from abdcdb3.Thanks!
The text was updated successfully, but these errors were encountered: