Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize current tests into integration and true unit tests #555

Open
shreyb opened this issue Mar 15, 2024 · 0 comments
Open

Organize current tests into integration and true unit tests #555

shreyb opened this issue Mar 15, 2024 · 0 comments
Labels
tests Fixes/improvements to tests

Comments

@shreyb
Copy link
Collaborator

shreyb commented Mar 15, 2024

We have a lot of tests marked unit tests that really aren't. Make sure we mark the true unit tests "unit", and the ones that are testing one functionality, but rely on external dependencies (like fake_ifdh stuff) as "unit-dependent" or something like that, if we don't want to call them "integration". That way, we can run the true unit tests in a github action until we can figure out how to mock certain external dependencies and make them true unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Fixes/improvements to tests
Projects
None yet
Development

No branches or pull requests

1 participant