Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key to JOBSUB_POOL_MAP map that allows for desired_usage_model to be overridden #524

Open
shreyb opened this issue Jan 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@shreyb
Copy link
Collaborator

shreyb commented Jan 30, 2024

@njpfnal brought up the fact that for some pools (like the DUNE global pool), our assumption that --onsite == DEDICATED,OPPORTUNISTIC doesn't hold (he believes that it's supposed to be OFFSITE for everything, but he will confirm that before we start work on this issue).

He requests that we have some sort of override. Maybe it could look something like:

$ echo $JOBSUB_POOL_MAP
{"dune":{"collector":"collector_host","onsite":"SITE_FOR_ONSITE","onsite_usage_model":"setting_for_onsite","offsite_usage_model":"setting_for_offsite}}

In the case of the DUNE global pool, if Nick's original assumption is correct, we would set, onsite_usage_model:"OFFSITE" and update the code to look for this setting.

@shreyb shreyb added enhancement New feature or request proposed Hasn't been reviewed by the jobsub team. Don't do these until post-review (and then remove label) labels Jan 30, 2024
@shreyb
Copy link
Collaborator Author

shreyb commented Feb 1, 2024

After discussing this at the jobsub project meeting on 2024-01-31, we approved this issue, but with some modifications.

  1. If a user specifies --site, we should just set the desired_usage_model to DEDICATED,OPPORTUNISTIC,OFFSITE, since most GlideinWMS Frontends are configured to make sure that their glideins match ONE of the desired_usage_model. This way, whether the user requests onsite or offsite by using --site, their job will match.
  2. If a user specifies --onsite, it should mimic the logic of --site=ONSITE_SITE_NAME (it would be great to call the same code pat in fact), where ONSITE_SITE_NAME gets populated from the JOBSUB_POOL_MAP or from the in-code default. desired_usage_model would get set to DEDICATED,OPPORTUNISTIC,OFFSITE like (1).
  3. If a user specifies --offsite, we should set the desired_usage_model to OFFSITE.
  4. Still keep the restriction where --onsite, --offsite, and --site are mutually exclusive.
  5. JOBSUB_POOL_MAP should remain as is. With the changes in (1)-(4), there is no reason to modify the functionality of JOBSUB_POOL_MAP any further.

@shreyb shreyb removed the proposed Hasn't been reviewed by the jobsub team. Don't do these until post-review (and then remove label) label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant