Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pull Request] Full Markdown support #20

Closed
nonunknown opened this issue Aug 9, 2020 · 1 comment
Closed

[Pull Request] Full Markdown support #20

nonunknown opened this issue Aug 9, 2020 · 1 comment

Comments

@nonunknown
Copy link

nonunknown commented Aug 9, 2020

Hi fenix, hope you remember me, I could do a pull request but first I want to know your toughts, As you know (or not) I've made this proposal:

godotengine/godot-proposals#1323

In order to make it possible, a description.md file is required, I did know your markdown system, but it doesnt support all markdown features, so I've made it, so if you want to include it on your project I made this issue!

Before:

Screenshot from 2020-08-09 16-15-27

After:
Screenshot from 2020-08-09 16-16-03
Screenshot from 2020-08-09 16-15-58
Screenshot from 2020-08-09 16-15-50

As you can see, it gets online images, stores in a folder, so its one time download, (only support PNG for now)
What it supports now:

  • Images
  • This list Im typing now
  • Explicit urls (click and go to page)
  • Non-Explicit urls like this
  • inline code
  • multiline code
  • Headers (#) from 1-6
  • some minor fixes

If you want the source just tell me!

@fenix-hub
Copy link
Owner

Hi @nonunknown ,
Thank you for this effort.

Make a Pull request whenever you want, I'll review it and if everything is fine I'll merge it to this plugin with no problem whatsoever.
The source is mandatory since, before merging the pull request, I still need to review it to make sure that everything is fine with the rest of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants